Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 12, 2022

Description

To run

$ git checkout demo-nifi-kafka-druid-water-level-data
$ stackablectl --additional-demos-file demos/demos-v1.yaml demo install nifi-kafka-druid-water-level-data

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

sbernauer and others added 19 commits September 9, 2022 15:27
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
….adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer sbernauer marked this pull request as draft September 12, 2022 11:05
@sbernauer sbernauer self-assigned this Sep 12, 2022
@sbernauer sbernauer marked this pull request as ready for review September 12, 2022 14:30
@sbernauer sbernauer requested a review from a team September 12, 2022 14:30
@maltesander maltesander self-requested a review September 13, 2022 08:49
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works. Only minor things.

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 13, 2022
## Description

To run
```
$ git checkout demo-nifi-kafka-druid-water-level-data
$ stackablectl --additional-demos-file demos/demos-v1.yaml demo install nifi-kafka-druid-water-level-data
```
@bors
Copy link

bors bot commented Sep 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add demo nifi-kafka-druid-water-level-data [Merged by Bors] - Add demo nifi-kafka-druid-water-level-data Sep 13, 2022
@bors bors bot closed this Sep 13, 2022
@bors bors bot deleted the demo-nifi-kafka-druid-water-level-data branch September 13, 2022 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants